karmada
karmada copied to clipboard
karmada-io
secret mount name fix
What type of PR is this? /kind bug
What this PR does / why we need it: Fixes cert mount name for metrcis adapter Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Fixed cert mount name for metrcis adapter
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @claudiuvintila! It looks like this is your first PR to karmada-io/karmada 🎉
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.29%. Comparing base (
81acb31) to head (97100e3). Report is 24 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #5014 +/- ##
=======================================
Coverage 53.29% 53.29%
=======================================
Files 252 253 +1
Lines 20495 20560 +65
=======================================
+ Hits 10922 10958 +36
- Misses 8851 8876 +25
- Partials 722 726 +4
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 53.29% <ø> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @claudiuvintila do we still this PR? Look forward your response,
