karmada icon indicating copy to clipboard operation
karmada copied to clipboard

feat:sign image for helm chart

Open liangyuanpeng opened this issue 2 years ago • 6 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • sign image of helm chart
  • renmae hack/package-helm-chart.sh to hack/helm-chart-package.sh for classify
  • mv signImage() to util.sh and rename util::signImage()

Which issue(s) this PR fixes: Part2 of https://github.com/karmada-io/karmada/issues/3435

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Use cosign to sign  Images of karmada helm chart and karmada operator helm chart.

liangyuanpeng avatar Jul 26 '23 05:07 liangyuanpeng

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed. You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jul 26 '23 05:07 karmada-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (961aa69) 52.84% compared to head (f3d8587) 52.84%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3841   +/-   ##
=======================================
  Coverage   52.84%   52.84%           
=======================================
  Files         239      239           
  Lines       23558    23558           
=======================================
  Hits        12450    12450           
+ Misses      10432    10431    -1     
- Partials      676      677    +1     
Flag Coverage Δ
unittests 52.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 26 '23 06:07 codecov-commenter

@liangyuanpeng sorry for the delay. I'm not sure if I have enough time for this month, busying with KubeCon stuff recently.

RainbowMango avatar Sep 20 '23 06:09 RainbowMango

@RainbowMango No worry, this is a low level issue. My talk of karmada for kubecon shanghai is missed and still wish you have fun :smile:

liangyuanpeng avatar Sep 20 '23 07:09 liangyuanpeng

Oh, what a pity~

RainbowMango avatar Sep 20 '23 07:09 RainbowMango

Ask @zhzhuang-zju to take a look and help.

RainbowMango avatar Oct 31 '23 06:10 RainbowMango