karmada
karmada copied to clipboard
feat:sign image for helm chart
What type of PR is this?
/kind feature
What this PR does / why we need it:
- sign image of helm chart
- renmae
hack/package-helm-chart.shtohack/helm-chart-package.shfor classify - mv
signImage()to util.sh and renameutil::signImage()
Which issue(s) this PR fixes: Part2 of https://github.com/karmada-io/karmada/issues/3435
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Use cosign to sign Images of karmada helm chart and karmada operator helm chart.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
961aa69) 52.84% compared to head (f3d8587) 52.84%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #3841 +/- ##
=======================================
Coverage 52.84% 52.84%
=======================================
Files 239 239
Lines 23558 23558
=======================================
Hits 12450 12450
+ Misses 10432 10431 -1
- Partials 676 677 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 52.84% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@liangyuanpeng sorry for the delay. I'm not sure if I have enough time for this month, busying with KubeCon stuff recently.
@RainbowMango No worry, this is a low level issue. My talk of karmada for kubecon shanghai is missed and still wish you have fun :smile:
Oh, what a pity~
Ask @zhzhuang-zju to take a look and help.