dashboard
dashboard copied to clipboard
karmada-io
Fix Issue #24: Manually Generate Secret for K8s v1.24+
What type of PR is this? /kind bug
What this PR does / why we need it: The background story is that since K8s v1.24+, service account by default doesn't create secret automatically. As the result, if we follow the old instruction, we can't get a login token, because there is no secret present.
Potential Solutions:
- Use K8s v1.23.
- Manually create a secret. (This PR)
- Adapt to new API, TokenRequest API
More discussion can be found here: https://github.com/karmada-io/karmada/issues/1961 https://github.com/karmada-io/karmada/pull/1972 https://itnext.io/big-change-in-k8s-1-24-about-serviceaccounts-and-their-secrets-4b909a4af4e0
My Solution: The second one. This assumes you use k8s v1.24+.
Add instruction in README.me for modifying karmada-dashboard-role.yaml, to manually create secret for us to see the login token. Then we can login the dashboard.
Which issue(s) this PR fixes: Fixes #24
Signed-off-by: Jun Xiang [email protected]
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I test find the secret dashboardsecret is deleted immediately after created
/close
As we are currently Refactoring the dashboard and the readme file has been significantly changed. Thank you @ada2468 all the same.
@RainbowMango: Closed this PR.
In response to this:
/close
As we are currently Refactoring the dashboard and the readme file has been significantly changed. Thank you @ada2468 all the same.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.