Karl Glazebrook
Karl Glazebrook
One could fix this by reversing FG/BG in the code after the call. Then my test would produce the same result. It might be more work to reproduce the other...
A few more comments @mbektas - the issue where it DUPLICATES all the notebook tabs from the previous window, is actually I think a bug and unrelated to the enhancement...
@bd-j @jrleja Just to add my oar in here. We have confirmed that our fitting issues were due to the use of` np.interp `in the prospector code for the resampling...
Hi @bd-j I believe the issue here is not so much 'interpolation' but that the code using np.interp() to do the binning up step. In the case of coarse pixels...
We definitely found we got the wrong outputs until we switched the code from np.interp to spectres. You could see by eye that the binning was incorrect. @themiyan can you...
Hmm I see we have not posted the worked example. Sorry about that! To answer your questions: By 'coarse' I simply mean the low resolution of NIRSPEC PRISM, we are...
yes, for low res data (e.g. NIRSPEC prism) the use of` np.interp ` in the prospector code for the resampling step causes serious problems. This kind of linear interpolation really...
PS found this when I was building a complex set of libraries (incl. GSL) some with c and some with fortran hence was trying to use consistent gcc and gfortran...
The problem is that it results in libgsl not passing its tests. Perhaps the test there is too stringent (it checks two floating point values are identical within some epsilon)...