Karel Ledru

Results 70 comments of Karel Ledru

I confirm that count is not accurate is some cases. It caused me quite a little headache and should be documented better imo: ``` ruby ratelimit = Ratelimit.new('email') ratelimit.add(email) ratelimit.count(email,...

My first reaction is that this is highly specific and I'm a little reluctant (but not opposed) to complicate the code for something your project likely be the only one...

@jeremyosborne see https://github.com/i18next/i18next-parser/pull/56

A key can appear in multiple files. The idea was for translator to know where the key come from to look for context.

You are welcome to open a PR.

@amandapouget The best is really to open a PR with a failing test case. A PR would be welcome to fix this.

I'll happily review a PR for this!

@boredland I think a flag to disable it entirely would work. Do you need this feature too?

I don't think what you need is related to the original issue. I'm ok to introduce a flag to disable the entire pluralization but I'm not keen to add more...

Thanks for the PR. I believe a more consistent fix would be to throw a warning. You can see [here](https://github.com/i18next/i18next-parser/blob/92e7b4164eb2ca3bbb6db2a1442296f9852f5e3c/test/parser.test.js#L2351) and [here](https://github.com/i18next/i18next-parser/blob/38c0d9beea956472bbeb519b5678ea27a2b452e6/src/lexers/javascript-lexer.js#L147). Would you mind adding the warning and a...