playkit-js-ui icon indicating copy to clipboard operation
playkit-js-ui copied to clipboard

feat(FEC-9942): change ui of the icons state

Open RoyBregman opened this issue 5 years ago • 1 comments
trafficstars

Description of the Changes

For icons in the top bar - added hover and active effects Buttons were enlarged from 32px to 36px but padding / margins adjusted in a manner that there should be no effect on buttons size and position from today (Should only enlarge the button background size)

In addition made some cosmetic fixes:

  • Removed huge redundant switch case from icons.js - only needed to rename the rewind10 and forward10 to rewind-10 and forward-10.
  • changed hard coded #01accd color to $brand-color

CheckLists

  • [X] changes have been done against master branch, and PR does not conflict
  • [ ] new unit / functional tests have been added (whenever applicable)
  • [X] test are passing in local environment
  • [X] Travis tests are passing (or test results are not worse than on master branch :))
  • [ ] Docs have been updated

RoyBregman avatar Aug 13 '20 06:08 RoyBregman

Hi @RoyBregman, Thank you for contributing this pull request! Please sign the Kaltura CLA so we can review and merge your contribution. Learn more at http://bit.ly/KalturaContrib

kaltura-hooks avatar Aug 24 '22 17:08 kaltura-hooks