mini-graph-card icon indicating copy to clipboard operation
mini-graph-card copied to clipboard

[Feature request] Add loading indicator

Open Misiu opened this issue 5 years ago • 7 comments
trafficstars

Recently HA added loading state to graphs: https://github.com/home-assistant/frontend/pull/5448 I think it would be a good improvement to add similar functionality here. Now you see an empty card that will show graph after some time. Showing the loading indicator will show user that something is happening and he must wait a bit longer.

This is my current setup. As you can see the current value is displayed, but it need some time to load the graph. mini_graph

Misiu avatar May 04 '20 09:05 Misiu

Yes, great suggestion, fetching data can be slow so a loading indicator would be nice.

kalkih avatar May 04 '20 19:05 kalkih

@kalkih should this be added to renderGraph function (https://github.com/kalkih/mini-graph-card/blob/master/src/main.js#L283)?

Misiu avatar May 18 '20 11:05 Misiu

Yes that could be a good place to add it.

kalkih avatar May 18 '20 13:05 kalkih

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this is still an active issue, please let us know!

stale[bot] avatar Feb 07 '22 01:02 stale[bot]

Could be informative.

ildar170975 avatar Feb 07 '22 22:02 ildar170975

Still an active issue, got it! Removing stale label.

stale[bot] avatar Feb 07 '22 22:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this is still an active issue, please let us know!

stale[bot] avatar Apr 09 '22 11:04 stale[bot]