kafka-streams-machine-learning-examples icon indicating copy to clipboard operation
kafka-streams-machine-learning-examples copied to clipboard

Published 20 hours ago • verified publisher icon kaiwaehner

Class static used to pass info between stream steps

Open jukkakarvanen opened this issue 6 years ago • 4 comments

Kafka_Streams_TensorFlow_Image_Recognition_Example use class static variables to pass information between foreach and mapValues steps.

So I expect rather interesting problems if executed with multiple threads.

I have fix for this, but it is on top of changes related to #11

jukkakarvanen avatar Mar 29 '19 12:03 jukkakarvanen

Similar problems noticed also in other classes.

jukkakarvanen avatar Mar 29 '19 12:03 jukkakarvanen

Yeah, to be honest, my first implementation was "quick and dirty", also I am not coding daily anymore - thus, I forgot some best practices about Java coding in last years :-)

Thank you so much for these improvements and pull requests.

kaiwaehner avatar Apr 03 '19 14:04 kaiwaehner

I merged your fix. Thank you.

I will keep the ticket open as reminder for the other classes. I will refactor the other classes, too.

kaiwaehner avatar Apr 12 '19 22:04 kaiwaehner

@jukkakarvanen Hey! im a newbie at this... im trying to run this repo using mvn clean package. Do I have to use kafka as well? or just use mvn clean package and everything would run? kindly help me out on this.

hamzakhalil798 avatar Jun 15 '22 10:06 hamzakhalil798