kairos icon indicating copy to clipboard operation
kairos copied to clipboard

[WIP] Add osv scanning for PRs

Open mauromorales opened this issue 1 year ago • 1 comments
trafficstars

relates to https://github.com/kairos-io/kairos/issues/2647

mauromorales avatar Jun 28 '24 09:06 mauromorales

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

saw this on the ovs

Skipping call analysis on Go code since Go is not installed.

Is this correct?

Itxaka avatar Jul 01 '24 12:07 Itxaka

saw this on the ovs

Skipping call analysis on Go code since Go is not installed.

Is this correct?

Good question, my guess is that it doesn't see anything but the go.mod and go.sum files so not the tests dir with the go code there. But do we want to test the tests dir? Since it's not shipped to the user

mauromorales avatar Jul 01 '24 13:07 mauromorales

I think it's ok because by default it runs recursively

mauromorales avatar Jul 01 '24 14:07 mauromorales