celery-pool-asyncio icon indicating copy to clipboard operation
celery-pool-asyncio copied to clipboard

Refactor `celery-pool-asyncio` to make it ready to merge into `celery` upstream

Open kai3341 opened this issue 5 years ago • 13 comments
trafficstars

Waiting for total code review by @auvipy

kai3341 avatar May 02 '20 14:05 kai3341

I need to fork and check on my local machine

auvipy avatar May 02 '20 15:05 auvipy

Hei, I would request you to open a PR against celery master :) that will be much easier to review and track the updates :)

auvipy avatar May 05 '20 07:05 auvipy

Also, you should fetch the necessary updates from the master branch of the repo you forked.

auvipy avatar May 05 '20 07:05 auvipy

hello, how was it going?

tony-is-coding avatar Jun 04 '20 03:06 tony-is-coding

i have added this to celery 4.5 feature list

auvipy avatar Jun 04 '20 05:06 auvipy

@auvipy how many time i have?

kai3341 avatar Jun 04 '20 21:06 kai3341

3 months ;) but don't be that late. would be great if you can start this month on WIP mode

auvipy avatar Jun 05 '20 00:06 auvipy

+1 for this feature. Currently this package works amazing for my use case.

Sharathmk99 avatar Jun 24 '20 22:06 Sharathmk99

you can target this to celery master now, which supports py 3.6+ only. I have started working on making kombu async as well. as we dropped python2 and master is 3.6+ only we can take some ideas from other projects like https://github.com/sqlalchemy/sqlalchemy/commit/9ccf4a2f659d77c7f1aacaa4ff2b3b16889fea5e

auvipy avatar Aug 18 '20 02:08 auvipy

@auvipy sure, i'll do it as soon as work rush will end. It looks like it's the last week of emergent work

kai3341 avatar Aug 18 '20 16:08 kai3341

ping me for discussion

auvipy avatar Aug 18 '20 16:08 auvipy

so.. how is it going?

NoraGithub avatar May 02 '22 15:05 NoraGithub

have to resume

auvipy avatar May 03 '22 03:05 auvipy