kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

FE: UX: Fix Multiple clusters' menu items selected at once

Open AlexisD02 opened this issue 1 year ago • 5 comments

What changes did you make?

This pull request addresses a bug in Kafka UI where it was not clear which Kafka instance was being displayed. Previously, the sidebar options (e.g., Topics, Brokers, Consumers) were highlighted for all Kafka instances, causing confusion.

Changes Include:

  • Updated the page header to display <instance name> Topics instead of just "Topics" to clearly indicate which Kafka instance is being viewed.
  • Ensured that the selected menu option is highlighted only for the Kafka instance currently being displayed, improving the clarity of navigation.

Is there anything you'd like reviewers to focus on?

Please review the changes to ensure:

  • The page header correctly reflects the current Kafka instance.
  • The sidebar highlights only the selected menu option for the active Kafka instance.

Fixes #694

AlexisD02 avatar Sep 11 '24 13:09 AlexisD02

I don't get how is this related to #324 which is about tab's title?

Thanks for pointing this out! I looked for the issue related to my task but couldn't find anything. Could you point me to the correct issue if I'm missed something?

AlexisD02 avatar Sep 26 '24 06:09 AlexisD02

I don't get how is this related to #324 which is about tab's title?

Thanks for pointing this out! I looked for the issue related to my task but couldn't find anything. Could you point me to the correct issue if I'm missed something?

I believe there's no issue related to these changes. I haven't experienced the issue you're describing either, as this is supposed to be a bugfix, let's file a bug report first, as I'm not being able to reproduce this. image

Haarolean avatar Sep 27 '24 22:09 Haarolean

I'm experiencing the same issue using main tagged image from docker hub image

hotsezus avatar Dec 04 '24 15:12 hotsezus

@hotsezus any specific steps to reproduce?

Haarolean avatar Dec 04 '24 16:12 Haarolean

@hotsezus any specific steps to reproduce?

Nothing special. Just use kafbat/kafka-ui:e7df880cdebe3977d06edee54a538bcaf9416649 image setting up connection to multiple clusters using config.yaml

Here is a compose.yml example:

services:
  kafbat-ui:
    image: kafbat/kafka-ui:e7df880cdebe3977d06edee54a538bcaf9416649
    restart: on-failure
    ports:
      - 8080:8080
    environment:
      DYNAMIC_CONFIG_ENABLED: 'true'
    volumes:
      - ./config.yml:/etc/kafkaui/dynamic_config.yaml

hotsezus avatar Dec 04 '24 17:12 hotsezus

Should be fixed within #1120 and/or #984

Haarolean avatar Jun 05 '25 15:06 Haarolean