kafka-ui icon indicating copy to clipboard operation
kafka-ui copied to clipboard

BE: RBAC: Ignore values for non-applicable resources

Open wernerdv opened this issue 1 year ago • 2 comments

  • [ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Fixed https://github.com/kafbat/kafka-ui/issues/253

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • [x] No need to
  • [ ] Manually (please, describe, if necessary)
  • [ ] Unit checks
  • [ ] Integration checks
  • [ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • [x] My changes generate no new warnings (e.g. Sonar is happy)
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

wernerdv avatar Jul 26 '24 20:07 wernerdv

@Haarolean Can you tell me if a unit test is needed for this refinement? Is there anything I can do to improve PR (for example adding logging)?

wernerdv avatar Sep 26 '24 08:09 wernerdv

@wernerdv I was hesitant to merge this as I thought there might be some other corner cases and given we don't have tests for RBAC at all, I have to eyeball this as much as possible. I wouldn't push you to write all the tests for RBAC within the scope of this issue.

Haarolean avatar Sep 27 '24 22:09 Haarolean

should be good @wernerdv thank you and sorry for the delay with this. Raised #729 to finally cover the RBAC parts with tests

Haarolean avatar Dec 28 '24 07:12 Haarolean