Add ability to select devices based on NIC names

[ian-howell]

What would you like to be added?

I would like to be able to create configmaps which allow for the sriov-device-plugin to select NICs based on their names, e.g.

{
    "resourceList": [{
            "resourceName": "sriov_netdevice",
            "selectors": {
                "nicNames": ["net1", "net2"]
            }
        }
}

What is the use case for this feature / enhancement?

This is useful when creating a device in libvirt, as the targets for the current selectors are unknown at VM creation time.

[SchSeba]

Hi @ian-howell can you explain the use-case a bit more?

for virtual environments we mainly use pciAddresses will that cover your use-case?

[ian-howell]

I'm generating the SRIOV-DP configmap prior to the creation of any VMs. In my case, I'm creating a VM template which is then used by kubevirt to later generate the actual VM. Even though I could specify a pci address for the device in the template, libvirt doesn't guarantee that the resulting device will actually get that address (libvirt docs). However, that isn't the case for other device info such as NIC name or MAC address

[ian-howell]

@SchSeba Any updates on this?

[SchSeba]

@ian-howell Thanks for the info!

[SchSeba]

Hi @ian-howell

can you please have a look on this links and let me know if that solve your use case

https://kubevirt.io/user-guide/virtual_machines/interfaces_and_networks/ https://github.com/kubevirt/kubevirt/blob/main/docs/sriov.md https://dougbtv.com/nfvpe/2019/05/15/kubevirt-sriov/

[SchSeba]

Hi @ian-howell can we close this isse?

[ian-howell]

Hey @SchSeba, after some investigation, I've found that the pfNames selector isn't sufficient for our use cases. I need to be able to target the device as it is named within the VM.

[SchSeba]

closing this one as we implement the ACPI instead https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/pull/488