quickstart-docker-git icon indicating copy to clipboard operation
quickstart-docker-git copied to clipboard

Published 20 hours ago • verified publisher icon k8s-platform-hub

Adds git push template for python webapp2 with google_app_engine sdk

Open jin09 opened this issue 8 years ago • 6 comments

Added git push template for python webapp2. Tested on hasura local dev setup

jin09 avatar Jul 18 '17 08:07 jin09

@jin09 Thanks for the PR!

I've never used the jetbrains python IDE before, but I don't think we should be committing the .idea directory. If you're sure about this can you point me to a reference that says it's fine? Here's a reference: https://stackoverflow.com/questions/11968531/what-to-gitignore-from-the-idea-folder

Also, can you include a .gitignore file?

I'll test it out in the meanwhile :)

coco98 avatar Jul 18 '17 09:07 coco98

I have now included the .gitignore file and removed .idea folder which was unnecessary

jin09 avatar Jul 18 '17 10:07 jin09

Hi, Did you test it?

jin09 avatar Jul 26 '17 10:07 jin09

I have made a few changes, please review them.

jin09 avatar Aug 22 '17 10:08 jin09

@jin09 Sorry for being totally AWOL on this. I tried this out a while back and forgot to comment. I had a question: What is the local development workflow for this? Can you add instructions to the README? (Eg: pip install -r requirements.txt followed by python main.py? By local development I mean that I want to test my python app locally before deploying it.

coco98 avatar Aug 22 '17 14:08 coco98

@coco98 Workflow for local develoment is in the Dockerfile recipe itself. Or is there anything specific that you want me to add?

jin09 avatar Aug 23 '17 08:08 jin09