sherpa-onnx
sherpa-onnx copied to clipboard
Too small buffer size in Android demo
Here you use minimal buffer size, sometimes it can be 80 ms. If recognizer is slow and can't manage in 80 ms samples can get lost and accuracy will degrade.
https://github.com/k2-fsa/sherpa-onnx/blob/master/android/SherpaOnnx/app/src/main/java/com/k2fsa/sherpa/onnx/MainActivity.kt#L163
Its recommended to use bigger buffer, maybe 0.5 seconds to not compromise latency.
https://github.com/k2-fsa/sherpa-onnx/blob/a65cdc3d765d0200e6798ff430b9f6d745099520/android/SherpaOnnx/app/src/main/java/com/k2fsa/sherpa/onnx/MainActivity.kt#L163-L164
Do you mean we need to hardcode it to 0.5 seconds?
It can be max(minBufferSize, 0.5 * sample_rate)
Would you mind creating a PR to fix it?
Sure, I'll submit one a bit later
Sure, I'll submit one a bit later
thanks!