sherpa-onnx icon indicating copy to clipboard operation
sherpa-onnx copied to clipboard

Too small buffer size in Android demo

Open nshmyrev opened this issue 2 years ago • 5 comments

Here you use minimal buffer size, sometimes it can be 80 ms. If recognizer is slow and can't manage in 80 ms samples can get lost and accuracy will degrade.

https://github.com/k2-fsa/sherpa-onnx/blob/master/android/SherpaOnnx/app/src/main/java/com/k2fsa/sherpa/onnx/MainActivity.kt#L163

Its recommended to use bigger buffer, maybe 0.5 seconds to not compromise latency.

nshmyrev avatar Nov 06 '23 23:11 nshmyrev

https://github.com/k2-fsa/sherpa-onnx/blob/a65cdc3d765d0200e6798ff430b9f6d745099520/android/SherpaOnnx/app/src/main/java/com/k2fsa/sherpa/onnx/MainActivity.kt#L163-L164

Do you mean we need to hardcode it to 0.5 seconds?

csukuangfj avatar Nov 07 '23 00:11 csukuangfj

It can be max(minBufferSize, 0.5 * sample_rate)

nshmyrev avatar Nov 07 '23 00:11 nshmyrev

Would you mind creating a PR to fix it?

csukuangfj avatar Nov 07 '23 00:11 csukuangfj

Sure, I'll submit one a bit later

nshmyrev avatar Nov 13 '23 22:11 nshmyrev

Sure, I'll submit one a bit later

thanks!

csukuangfj avatar Nov 13 '23 23:11 csukuangfj