sherpa-onnx icon indicating copy to clipboard operation
sherpa-onnx copied to clipboard

C# Objects that expect to be Disposed do not implement IDisposable

Open jacob-mink-1996 opened this issue 9 months ago • 0 comments

Hello

In the implementation for objects like OfflineTtsGeneratedAudio, I notice that there is a Dispose method but the class does not implement the IDisposable interface. This means we must manually call Dispose and cannot use the using pattern.

jacob-mink-1996 avatar Feb 12 '25 19:02 jacob-mink-1996