k0s icon indicating copy to clipboard operation
k0s copied to clipboard

Allow CPLB to work with externalAddress

Open juanluisvaladas opened this issue 1 year ago • 4 comments

Description

Allow this behavior if the endpoint-reconciler is disabled.

K0smotron needs to use external address for cluster API. The only limitation why we couldn't combine externalAddress and CPLB is the endpoint-reconciler, since it can be disabled, allow to run CPLB with externalAddress if the user manually disables it.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Documentation update

How Has This Been Tested?

  • [x] Manual test
  • [x] Auto test added

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] My commit messages are signed-off
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

juanluisvaladas avatar May 20 '24 12:05 juanluisvaladas

K0smotron needs to use external address for cluster API.

Can you elaborate? K0smotron can simply use the CPLB addresses without k0s using them. Is that backport really required?

twz123 avatar May 22 '24 06:05 twz123

Can you elaborate? K0smotron can simply use the CPLB addresses without k0s using them.

Yes, but k0smotron would have to be modified as it's hardcoded to set the externalAddress. That's an option too.

Is that backport really required?

From a purely technical point of view no, but this was requested by sales and it's important for one potential customer. I don't see many downsides to backporting so I'd say we should backport it.

juanluisvaladas avatar May 22 '24 10:05 juanluisvaladas

I think i slowly get what this is about :sweat_smile: Can you maybe write up an example use case to better explain what this PR actually unblocks?

twz123 avatar May 23 '24 14:05 twz123

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jun 22 '24 23:06 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Jul 24 '24 23:07 github-actions[bot]

The PR is marked as stale since no activity has been recorded in 30 days

github-actions[bot] avatar Aug 25 '24 23:08 github-actions[bot]

Closing this for now. Will reopen after merging userspace reverse proxy.

juanluisvaladas avatar Aug 26 '24 07:08 juanluisvaladas