jwt icon indicating copy to clipboard operation
jwt copied to clipboard

Added support for JSON Web key sets

Open CADBIMDeveloper opened this issue 1 year ago • 9 comments

Description

Based on #488 , adds JWKS support

Breaking changes

None

Checklist

  • [x] Tests added
  • [x] Version bumped
  • [x] Changelog updated

CADBIMDeveloper avatar Jan 27 '24 11:01 CADBIMDeveloper

Привет, @abatishchev,

It's currently far away from fully ready, anyway, take a look please. Would like to hear from you, if you agree or not about namespaces, naming and the approach itself

CADBIMDeveloper avatar Jan 27 '24 11:01 CADBIMDeveloper

Александр, @abatishchev, do I need to add/fix something here? Ping :-)

CADBIMDeveloper avatar Feb 08 '24 05:02 CADBIMDeveloper

Thank you so much for your contribution! It's a lot and more than I expected. Please allow me some time to review it. Will do :)

abatishchev avatar Feb 08 '24 05:02 abatishchev

My sincere apologies! It felt through the cracks of my memory, but now it's back and I'll review the changes as part of the upcoming major version release. Once again, thanks for your contribution!

abatishchev avatar Apr 16 '24 14:04 abatishchev

hey @CADBIMDeveloper, I'm back to the PR, as promised :) can you please check why all tests are failing? and rebase on the latest main please too.

abatishchev avatar Apr 29 '24 20:04 abatishchev

Hey @abatishchev ,

Hypothesis: You've removed src/Directory.Build.targets where MODERN_DOTNET constant was defined. I will check and fix it this week.

CADBIMDeveloper avatar Apr 30 '24 06:04 CADBIMDeveloper

Yeah, it was removed in #497, the .NET team has confirmed that it's better not to reference it until strictly necessary, e.g. in lower target frameworks which don't ship it within

abatishchev avatar Apr 30 '24 14:04 abatishchev

Hey @abatishchev , it's working now :-)

CADBIMDeveloper avatar May 01 '24 08:05 CADBIMDeveloper

hey @CADBIMDeveloper, I'm sorry again, I didn't forget - the tab is permanently open for me. It's just a bit too chaotic at work right now. I'll come back to this PR as soon as I can.

abatishchev avatar May 13 '24 17:05 abatishchev