emacs-async icon indicating copy to clipboard operation
emacs-async copied to clipboard

Some tests on Macos and Windows are failing

Open thierryvolpiatto opened this issue 1 year ago • 10 comments
trafficstars

Hello @Fuco1, after each commit I receive a mail saying build fails on several platforms: https://github.com/jwiegley/emacs-async/actions/runs/9542738192/job/26298070538#step:3:334 An idea of what's wrong?

thierryvolpiatto avatar Jun 17 '24 06:06 thierryvolpiatto

The macos tests seem to not provide older emcas versions anymore:

  error: flake 'github:purcell/nix-emacs-ci' does not provide attribute 'packages.aarch64-darwin.emacs-27-2', 'legacyPackages.aarch64-darwin.emacs-27-2' or 'emacs-27-2'
         Did you mean one of emacs-28-2, emacs-29-2, emacs-28-1, emacs-29-1 or emacs-29-3?

maybe @purcell can weigh in?

About the windows tests, there seems to be some issue with the code. I'll have to figure out a way to run the windows tests locally though :O

Fuco1 avatar Jun 17 '24 14:06 Fuco1

This is because macos-latest is now ARM (Apple Silicon), and only Emacs >= 28.2 build on that platform. For a while, it would be possible to include macos-11 to get Intel builds, but GitHub is soon going to remove those runners. So the solution here is, unfortunately, to stop expecting MacOS builds on earlier Emacs versions.

purcell avatar Jun 17 '24 14:06 purcell

BTW, easiest mechanism would be use exclude in the matrix portion of the github workflow, see https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations

purcell avatar Jun 17 '24 14:06 purcell

Thanks Matus and Steve to look into this!

thierryvolpiatto avatar Jun 17 '24 15:06 thierryvolpiatto

@jwiegley could you disable this mechanism in github actions until it be fixed?

thierryvolpiatto avatar Jul 05 '24 04:07 thierryvolpiatto

It should be disabled now.

jwiegley avatar Jul 05 '24 05:07 jwiegley

John Wiegley @.***> writes:

It should be disabled now.

Great, thanks.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.**>

-- Thierry

thierryvolpiatto avatar Jul 05 '24 06:07 thierryvolpiatto

I took a stab at fixing this -> #191

purcell avatar Jul 05 '24 09:07 purcell

@purcell Can we consider this issue closed now?

jwiegley avatar Sep 06 '24 17:09 jwiegley

@jwiegley I didn't fix the Windows side of this, but the MacOS side should be resolved.

purcell avatar Sep 09 '24 09:09 purcell