requirejs-rails icon indicating copy to clipboard operation
requirejs-rails copied to clipboard

Renamed incorrecly named build option 'wrap' to 'wrapShim'

Open ghost opened this issue 11 years ago • 2 comments

According to the RequireJS docs there is a build option called 'wrapShim', but I couldn't find any reference to wrap.

https://github.com/jrburke/r.js/blob/b8a6982d2923ae8389355edaa50d2b7f8065a01a/build/example.build.js#L68

ghost avatar Oct 09 '14 21:10 ghost

I think it is safe to automatically merge, would make life easier to simply depend on a git version of the gem at least :)

Rush avatar Oct 22 '14 02:10 Rush

Would be great to have this merged in. We have needed this for over a year now to get our production precompile to work.

We are using several older libraries that are not module friendly and try to populate the global scope. These will not work without the wrapShim option.

thegillis avatar Aug 08 '16 02:08 thegillis