BrowserFS icon indicating copy to clipboard operation
BrowserFS copied to clipboard

fix a recursion bug when parent directory path is '.'

Open kevinramharak opened this issue 4 years ago • 2 comments
trafficstars

Fixes #273

kevinramharak avatar Feb 01 '21 01:02 kevinramharak

LGTM. @jvilk ?

emeryberger avatar Feb 01 '21 13:02 emeryberger

I cannot seem to get the test to run locally nor will they work on the CI. This PR does not fix the issue completely but it will stop thet stack overflow

kevinramharak avatar Feb 01 '21 15:02 kevinramharak

Can we get this merged?

evanmcarlson avatar Jan 06 '23 19:01 evanmcarlson

@evanmcarlson can you confirm that this works? (The CI fails; it'd be nice to have that fixed.)

emeryberger avatar Jan 06 '23 23:01 emeryberger

As it seems this project is now unmaintained, I forked it and have added most of the PRs that were left open, including this one :) https://github.com/Froggo8311/BrowserFS

NovaAndrom3da avatar Feb 11 '23 04:02 NovaAndrom3da

@Froggo8311 If you plan to maintain your fork, you might want to rename and detach from this repository, and activate issues.

trasherdk avatar Feb 15 '23 02:02 trasherdk

@trasherdk Good idea, thanks :)

NovaAndrom3da avatar Feb 15 '23 02:02 NovaAndrom3da

Hi all - as long as someone is willing to verify that the PRs are correct, I am happy to merge them. @jvilk is busy with his family and can’t maintain this work right now.

emeryberger avatar Feb 15 '23 03:02 emeryberger

@Froggo8311 @trasherdk

As it seems this project is now unmaintained, I forked it and have added most of the PRs that were left open, including this one :)

I've become a maintainer for the project recently so BFS should be maintained.

james-pre avatar Mar 10 '23 00:03 james-pre

@Froggo8311 @trasherdk

As it seems this project is now unmaintained, I forked it and have added most of the PRs that were left open, including this one :)

I've become a maintainer for the project recently so BFS should be maintained.

Okay, sounds good

NovaAndrom3da avatar Mar 10 '23 01:03 NovaAndrom3da