xeus-python-kernel icon indicating copy to clipboard operation
xeus-python-kernel copied to clipboard

Inclusion of `wasm`, `tar.gz` and other ignored files in the hatch `shared-data`

Open jtpio opened this issue 2 years ago • 0 comments

As noticed in https://github.com/jupyterlite/xeus-python-kernel/pull/181#issuecomment-1767950367, there seems to be an issue with hatch not picking up the files listed in .gitignore.

As a result, they are not included in the wheel shared-data and cause issues like https://github.com/jupyterlite/xeus-python-kernel/issues/177 since some files are missing.

https://github.com/jupyterlite/xeus-python-kernel/pull/181 updated the .gitignore to narrow the scope of the ignored files, so they can be included in the wheel correctly.

However this feels a bit error-prone and it would be easy to get back to the same issue by adding new entries to the .gitignore.

Some next steps would be:

  • make a standalone repo to reproduce this issue
  • open an issue / discussion on https://github.com/pypa/hatch if this is reproducible with the test repo
  • add a check on CI here to make sure files are correctly included. Or run a small UI test with the production build of jupyterlite-xeus-python to make sure the kernel can at least without errors

jtpio avatar Oct 18 '23 08:10 jtpio