Support host and ref options in Menu.open

[ianthomas23]

trafficstars

Implements enhancement #699.

This exposes the Widget.attach optional arguments host and ref in Menu.IOptions to provide greater control over exactly where in the DOM the menu div is attached.

I have kept the names and descriptions of the options the same as in Widget.attach.

[welcome[bot]]

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

[krassowski]

You will need to run yarn run api and commit changes.

[fcollonval]

in addition to the API update, you will need to lint the code with yarn lint. One of the tests is failing due to

[warn] packages/widgets/tests/src/menu.spec.ts

[ianthomas23]

Thanks for the guidance @krassowski and @fcollonval. I've added the extra documentation to Menu.open, although it could possibly be added to IOpenOptions instead, as that was my entry point into the docs. I've also switched the || to ?? in the new code whilst I was there.

[ianthomas23]

I cannot tell if the failing macos-latest webkit-headless CI run is something that I have caused or if it is unrelated.

[fcollonval]

I cannot tell if the failing macos-latest webkit-headless CI run is something that I have caused or if it is unrelated.

This is due to flakiness - I let @krassowski have a second look.

[fcollonval]

gentle ping to @krassowski

[welcome[bot]]

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart: