lumino icon indicating copy to clipboard operation
lumino copied to clipboard

Published 20 hours ago • verified publisher icon jupyterlab

Touch Events -> Resize widgets

Open martaszmit opened this issue 4 years ago • 13 comments
trafficstars

Hello! First of all I would like to thank you guys for last changes in Lumino and for possibility to rearrange widgets on touch screens (@bign8 👏 ).

Regarding this changes, would be great to add possibility to resize widgets on touch screens as well.

What do you think about this proposal?

Cheers!

martaszmit avatar Oct 11 '21 07:10 martaszmit

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Oct 11 '21 07:10 welcome[bot]

Hi @martaszmit, yes, that makes sense. I believe the relevant changes would be in SplitPanel.handleEvent.

blink1073 avatar Oct 11 '21 13:10 blink1073

Thank you for hint :) I tried to take a look on it, but when I cloned a repository, installed dependencies I tried to run yarn build:src and it fails on @lumino/messaging build script. Did I something wrong? image

martaszmit avatar Oct 18 '21 13:10 martaszmit

What is the output of node --version?

blink1073 avatar Oct 18 '21 15:10 blink1073

v14.17.1

martaszmit avatar Oct 19 '21 06:10 martaszmit

Hmm, I just tried in a fresh environment with node v14.17.4 and yarn 1.22.17 on my macOS 11.6 and it built fine. What version of yarn and which OS are you using?

blink1073 avatar Oct 19 '21 11:10 blink1073

yarn 1.22.15 on windows 10 enterprise

martaszmit avatar Oct 19 '21 11:10 martaszmit

I also tried with Wndows 10 Pro and it built fine, we're also building against Windows in CI. I've not seen an error like that before, I'm not sure what else to suggest other than to try creating a new clean environment or use a conda environment to get node.

blink1073 avatar Oct 19 '21 12:10 blink1073

I confirm, works fine now, I started again in a fresh environment 👍

martaszmit avatar Oct 19 '21 14:10 martaszmit

Ha, node is definitely like that sometimes...

blink1073 avatar Oct 19 '21 14:10 blink1073

Hi, I spotted that, without any changes it works sometimes, quite randomly as you can see in the video below. I tried to add changes similar to these: https://github.com/jupyterlab/lumino/pull/123 in SplitPanel , but nothing has changed.

https://user-images.githubusercontent.com/19773837/138288421-0355107d-a8a1-459b-81c8-348156b81cae.mov

martaszmit avatar Oct 21 '21 13:10 martaszmit

I'm not able to view the video. Can you please push your work in progress to a pull request? We can look at the code together, and the changes will be testable from a tablet using the readthedocs build for the PR.

blink1073 avatar Oct 21 '21 20:10 blink1073

Of course, thank you :) PR is ready: https://github.com/jupyterlab/lumino/pull/251

martaszmit avatar Oct 22 '21 06:10 martaszmit