jupyterlab-desktop icon indicating copy to clipboard operation
jupyterlab-desktop copied to clipboard

Double clicking opens duplicate notebook instances on MacOS

Open karlglazebrook opened this issue 2 years ago • 9 comments

I was trying JupyterLab Desktop for the first time and set it to launch when double clicking on .ipynb files (which is nice).

The problem is it opens these in a new window each time AND duplicates all notebooks from the previous window!

So if I have files Untitled1.ipynb Untitled2.ipynb Untitled3.ipynb Untitled4.ipynb ... etc

Then double clicking on Untitled1.ipynb gives me a window with a Untitled1.ipynb tab

If I then double click on Untitled2.ipynb I get two windows -the new one has Untitled1.ipynb AND Untitled2.ipynb tabs while the old one still has the Untitled1.ipynb tab. Further they seem to be independent instances so editing one Untitled1.ipynb does not change the other. Lots of possibilities for conflicts.

If I double click on a third file this gets worse...I could not find a settings option to change this.

This really needs to be fixed!

(Version 3.6.1-1 on MacOS)

karlglazebrook avatar Feb 19 '23 07:02 karlglazebrook

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Feb 19 '23 07:02 welcome[bot]

@karlglazebrook thanks for reporting this, currently a new session is started for each file opened using double click. I plan to add options to open in the existing session when applicable. for your use case, once you have JupyterLab Desktop open, you can go to file explorer on the side and open those other files in the same directory more easily and they will be sharing the same session.

mbektas avatar Feb 20 '23 03:02 mbektas

Indeed, thanks for the response and sorry for the slow reply. I thought I had enabled notifications but clearly I had not.

'open in existing session' would be a valuable enhancement and provide a more integrated (in to the host OS) experience, which I think is part of the point of this app. It would also alleviate the fact that app startup is quite slow.

Meanwhile I will be careful and bare in mind your workaround.

Keep up the good work! This app is really needed.

karlglazebrook avatar May 25 '23 04:05 karlglazebrook

PS I see my issue survived the triage. Great!

karlglazebrook avatar May 25 '23 04:05 karlglazebrook

Any news on this? It still happening, if there is a setting I can't find it

karlglazebrook avatar Nov 10 '23 06:11 karlglazebrook

@karlglazebrook we haven't added support for this yet. sorry. I will keep this issue open since we would like to have this supported.

mbektas avatar Dec 17 '23 19:12 mbektas

Yes please, it does drive me batty! :-)

karlglazebrook avatar Jan 05 '24 06:01 karlglazebrook

There seems to be no progress on this? I thought it was a minor issue and seems relevant to new features like 'Zen mode' when opening files in MacOS finder.

karlglazebrook avatar Apr 13 '24 02:04 karlglazebrook

A few more comments @mbektas

  • the issue where it DUPLICATES all the notebook tabs from the previous window, is actually I think a bug and unrelated to the enhancement request. It is not good behaviour to erroneously open two sessions pointing to the same notebook. This will cause accidental overwrites I think.

  • further, this interacts in an unfortunate way with the zen mode. If I double click a single notebook in the Mac Finder and open it, it can open automatically in zen mode and then HIDE the other tabs (which potentially duplicate another session) which it opens in the bug case so you can't even see them.

Fixing the duplicates bug would be big win :-)

karlglazebrook avatar Jun 18 '24 06:06 karlglazebrook