frontends-team-compass icon indicating copy to clipboard operation
frontends-team-compass copied to clipboard

Published 20 hours ago • verified publisher icon jupyterlab

Hand off jupyterlab-favorites to jupyterlab team

Open shreddd opened this issue 5 years ago • 7 comments
trafficstars

The Jupyterlab Favorites (Add the ability to save favorite folders to JupyterLab for quicker browsing) feature has been tremendously useful, but the summer student who was working on it is no longer with our organization, and we are not ideally suited to supporting this.

Would it be possible to transition this repo/feature: https://github.com/NERSC/jupyterlab-favorites to the the Jupyterlab core team?

Note: @jasongrout suggested opening up an issue here

shreddd avatar Apr 14 '20 22:04 shreddd

Thanks @shreddd and @tslaton! I am personally in favor, and will bring it up at the team meeting tomorrow.

blink1073 avatar Apr 14 '20 23:04 blink1073

From today's meeting we agreed to bring it in as a reposotiry in the org to start. We would iterate and get feedback, and then later bring it in to core. In core, it would be disabled by default but have an easy path to enable it.

blink1073 avatar Apr 15 '20 16:04 blink1073

@shreddd and @blink1073 as I recently wrote a PR to port that extension in JupyterLab 2, I can work on this.

From that work,

  • [critical] Use state rather than settings to store favorites. The favorites stored in settings will only define the default list.
  • [major] extract dynamic menu from favorite manager
  • [minor][core] create an API to add a button at the end of the breadcumbs (suppress current hack)
  • [minor] add button on each favorite list item to remove them easily
  • [😉] testing

fcollonval avatar Apr 22 '20 08:04 fcollonval

We had discussion today about how to evolve contributed extensions, documented in #52

blink1073 avatar Apr 22 '20 17:04 blink1073

@shreddd to move things forward. I happily update and publish it for JLab2 if you grant me the rights on GitHub and NPM; this will avoid creating a fork.

Note my user name is fcollonval on both platforms.

fcollonval avatar Jun 16 '20 08:06 fcollonval

@shreddd just checking: are you still interested in handing off jupyterlab-favorites?

Looks like this could go to the jupyterlab-contrib org which now has quite of a couple of community repos? https://jupyterlab-contrib.github.io/

jtpio avatar Oct 15 '21 12:10 jtpio

Small note, it is for now forked in jupyterlab-contrib organization: https://github.com/jupyterlab-contrib/jupyterlab-favorites

But a transfer will be better.

fcollonval avatar Oct 15 '21 15:10 fcollonval