jupyterlab-vim
jupyterlab-vim copied to clipboard
jupyterlab-contrib
Status line font color conflict in Jupyterlab Dark Theme
Description
When setting the theme to Jupyterlab Dark, there is a font color conflict in status line. The text typed in the status line can not be seen due to font color issue. It can only be shown when highlighted with a mouse.
I found this after upgrading both Jupyterlab to 4.3.0 and jupyterlab-vim to 4.1.4. Dont know which one causes this issue.
Reproduce
Either open a text file in a text editor, or open a .ipynb file, hit :s or search with /
Context
- Browser and version: Chrome Version 130.0.6723.70 (Official Build) (64-bit)
- JupyterLab version: 4.3.0
- jupyterlab-vim version: 4.1.4
Looking at the ex prompt with the browser inspector, it seems like the panel is themed with CodeMirror mechanisms, and it doesn't seem like codemirror-vim is introducing any custom CSS rules or classes to cause the mismatch with the editor theme. Therefore, it seems like addressing this at the JupyterLab level would be more appropriate, instead of trying to hack the ͼ2 or cm-panels rules in the extension? @krassowski, do you have any suggestions?
Yes, it looks like this should be resolved in JupyterLab as .cm-panels is a class from @codemirror/view theme. I think a rule to override it would go in here. PR welcome!
This problem is not unique to jupyterlab_dark theme - basically any theme I've tried (theme-darcula, catppuccin-jupyterlab, jupyterlab_ariakedark_theme) the foreground and background color in the status line are the same.
Yes, it looks like this should be resolved in JupyterLab as
.cm-panelsis a class from@codemirror/viewtheme. I think a rule to override it would go in here. PR welcome!
I apologize if I have misread something but it I don't see anything even containing 'panel' in the file @krassowski linked. What file does @firai 's post refer to?
