nbgitpuller icon indicating copy to clipboard operation
nbgitpuller copied to clipboard

Don't hardcode 'master' into the link generator

Open yuvipanda opened this issue 1 year ago • 2 comments

Just leaving it empty now checks out HEAD, which is the default branch.

Fixes https://github.com/jupyterhub/nbgitpuller/issues/311

yuvipanda avatar Jan 09 '24 22:01 yuvipanda

It looks like the Binder tab stlil requires a branch, do you consider this within the scope of this PR?

https://nbgitpuller--337.org.readthedocs.build/en/337/link.html image

manics avatar Jan 10 '24 09:01 manics

@manics ah damn, it looks like the environment repository branch in the binder generated is actually reused to in the default generator. This sucks, because they both actually need different behavior - mybinder.org understands HEAD, but nbgitpuller does not. Ugh...

yuvipanda avatar Jan 10 '24 23:01 yuvipanda