nbgitpuller icon indicating copy to clipboard operation
nbgitpuller copied to clipboard

Can we stop needing notebook entirely?

Open consideRatio opened this issue 4 years ago • 3 comments

These are our references to notebook atm, can we transition away from using them entirely?

https://github.com/jupyterhub/nbgitpuller/blob/2fe5339c55212c51c144718659e65b02b785210d/nbgitpuller/handlers.py#L5

https://github.com/jupyterhub/nbgitpuller/blob/2fe5339c55212c51c144718659e65b02b785210d/nbgitpuller/init.py#L4

consideRatio avatar Sep 02 '21 19:09 consideRatio

I don't really understand how to make sure notebook extensions work with both classic notebook and jupyter_server :( I couldn't find anything written about it either - you got any ideas?

yuvipanda avatar Nov 08 '21 08:11 yuvipanda

@yuvipanda sorry no, I'm not knowledgeable about this =/ Perhaps @Zsailer knows if there is something written about making a notebook extension be compatible with both classic notebook and jupyter_server?

consideRatio avatar Nov 08 '21 08:11 consideRatio

I don't really understand how to make sure notebook extensions work with both classic notebook and jupyter_server

Isn't nbgitpuller already compatible with both?

  • https://jupyter-server.readthedocs.io/en/latest/developers/extensions.html#migrating-an-extension-to-use-jupyter-server
  • https://github.com/jupyterhub/nbgitpuller/blob/58d44d9418871bc96878f4c28cecf98559bf7d06/nbgitpuller/init.py#L32

manics avatar Nov 08 '21 11:11 manics