kubespawner icon indicating copy to clipboard operation
kubespawner copied to clipboard

profile_list → wrapspawner or jupyterhub

Open rkdarst opened this issue 5 years ago • 5 comments
trafficstars

Opening this mainly to track the related ideas so they don't get forgotten.

Proposed change

Transferring from https://github.com/jupyterhub/kubespawner/pull/393#issuecomment-703317048 could be relevant, discusses wrapspawner and how the profile list could be moved to wrapspawner. The profile_list has a lot of overlap with wrapspawner, info in the linked issue.

Another option is to move all of this to core JupyterHub: https://github.com/jupyterhub/jupyterhub/issues/2724

Alternative options

do nothing (and/or not fill this section in issue template)

Who would use this feature?

Other spawners who need essentially the same feature, and there are already two implementations

(Optional): Suggest a solution

"obvious", but needs discussion and work. I don't expect to have much time myself, though...

rkdarst avatar Oct 07 '20 17:10 rkdarst

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Oct 07 '20 17:10 welcome[bot]

@rkdarst I'm on an issue triaging spree in this repo, and would say that this is a question for KubeSpawner, not for the repo that consumes KubeSpawner, right?

consideRatio avatar Oct 07 '20 17:10 consideRatio

Yes, oops... I didn't see the repo I was opening on. Please triage.

rkdarst avatar Oct 07 '20 18:10 rkdarst

Would love for this to be in JupyterHub core, rather than wrapspawner!

yuvipanda avatar Oct 08 '20 09:10 yuvipanda

@yuvipanda Is it just the profile list that should go into JupyterHub core, or do you think the rest of WrapSpawner should also go in?

manics avatar Oct 08 '20 10:10 manics