jupyter-server-proxy icon indicating copy to clipboard operation
jupyter-server-proxy copied to clipboard

Consider moving JupyterLab launcher entries to the "other" category

Open ian-r-rose opened this issue 6 years ago • 18 comments

I find the placement of the launcher entries in JupyterLab in the "Notebook" section to be kind of weird, since they are mostly not notebooks. Why not put them in the "other" category?

ian-r-rose avatar Sep 04 '19 17:09 ian-r-rose

Or, perhaps make the category configurable?

ian-r-rose avatar Sep 04 '19 17:09 ian-r-rose

I think other makes sense.

manics avatar Sep 05 '19 09:09 manics

Is it possible to add an additional category? The Other category is visually far away from where people look :-/

betatim avatar Sep 05 '19 17:09 betatim

I just made this, maybe it should go here? https://github.com/jupyterhub/jupyter-rsession-proxy/issues/87

madsi1m avatar May 04 '20 06:05 madsi1m

Just ran into this - I think that JupyterLab should allow additional categories to be created by launcher items, otherwise using other would be helpful.

ellisonbg avatar Jul 21 '20 05:07 ellisonbg

https://github.com/jupyterlab/jupyterlab/issues/8663 is also an option. 'Other' puts everything below the fold, IMO, so we shouldn't put these there unless there is a way to make it more prominent.

yuvipanda avatar Jul 21 '20 06:07 yuvipanda

I just finished reading the Jupyter blog post on Elyra and I found out they were able to add an Elyra category to JupyterLab: image

The magic seems to be somewhere in here: https://github.com/elyra-ai/elyra/blob/master/packages/theme/src/launcher.tsx

So it looks like with ~200 lines of code, we should be able to add a "Proxy Server" category to JupyterLab if we wish to.

cmd-ntrf avatar Aug 10 '20 19:08 cmd-ntrf

Nice! Yes, I'm in favor of "Proxy Server" or just "Proxy" category.

ryanlovett avatar Aug 10 '20 19:08 ryanlovett

I like the idea of the Elyra launcher. Has anybody tried it? I will give it a go if not....

I do not like "Proxy Server" (it does not mean much to users!). What about "Applications" -- maybe if it is a jupyterlab extension the title can be also customised.

eddienko avatar Feb 07 '21 21:02 eddienko

I have done a quick start on this, but likely needs help. It needs a few things:

  • JupyterLab 3
  • The pull request linked above to be able to change the category of the proxy applications.
  • The extension here replaces the default launcher and allows to specify custom categories: https://github.com/eddienko/jupyterlab-apps-launcher -- see screenshots there -- (I believe https://github.com/eddienko/jupyterlab-apps-launcher/releases/download/v0.1.1/jupyterlab_apps_launcher-0.1.1-py3-none-any.whl can be installed with pip)

The status is much WIP: "Works for me".

eddienko avatar Feb 10 '21 09:02 eddienko

My vote would go for adding jupyter-server-proxy items to an Application category (or one or more custom ones) just below the Notebook category.

In that way I could move the "Panel HighCharts Apps" to some more relevant location.

image

MarcSkovMadsen avatar Apr 06 '21 05:04 MarcSkovMadsen

Resurrecting an old thread... I'm in favor of adding Jupyter Server Proxy launcher items to the "Application" category, as opposed to "Other". In fact, I would propose the following change to the launcher_entry config option:

launcher_entry:
    // no changes to these fields
    enabled: bool
    icon_path: str
    title: str

    // new optional field, where the default value is "Application"
    category: str

@eddienko What do you think? I noticed you have a draft PR up. If you're OK with this^ proposal, would you like some help with making changes in the PR?

claytonlemons avatar May 26 '23 05:05 claytonlemons

@claytonlemons @MarcSkovMadsen I'd +1 on being able to add server proxy applications to an Application or Applications area.

psychemedia avatar Apr 03 '24 16:04 psychemedia

Yes I think an 'Application' field would be quite perfect.

yuvipanda avatar Apr 03 '24 16:04 yuvipanda

+1

On Wed, Apr 3, 2024 at 9:51 AM Yuvi Panda @.***> wrote:

Yes I think an 'Application' field would be quite perfect.

— Reply to this email directly, view it on GitHub https://github.com/jupyterhub/jupyter-server-proxy/issues/145#issuecomment-2035103136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGXUCH4CPPNDW5MP4ZYU3Y3QXPPAVCNFSM4ITUSBW2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBTGUYTAMZRGM3A . You are receiving this because you commented.Message ID: @.***>

-- Brian E. Granger

Senior Principal Technologist, AWS AI/ML @.***) On Leave - Professor of Physics and Data Science, Cal Poly @ellisonbg on GitHub

ellisonbg avatar Apr 03 '24 16:04 ellisonbg

#453 enables the launcher category to be configurable. To satisfy this issue, the default category could be changed from "Notebook" to "Application".

ryanlovett avatar Apr 03 '24 17:04 ryanlovett

https://github.com/jupyterhub/jupyter-server-proxy/pull/453#issuecomment-1955741437 feels like a blocker to merging that though - we may lose icons?

yuvipanda avatar Apr 03 '24 17:04 yuvipanda

Icons are fairly easy to build hot in the labextension... Non-svg can be wrapped as foreignobjects

On Wed, Apr 3, 2024, 12:23 Yuvi Panda @.***> wrote:

#453 (comment) https://github.com/jupyterhub/jupyter-server-proxy/pull/453#issuecomment-1955741437 feels like a blocker to merging that though - we may lose icons?

— Reply to this email directly, view it on GitHub https://github.com/jupyterhub/jupyter-server-proxy/issues/145#issuecomment-2035171937, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCREYT7ZB6KF6KTW2E23Y3Q3HXAVCNFSM4ITUSBW2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBTGUYTOMJZGM3Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bollwyvl avatar Apr 03 '24 18:04 bollwyvl