grafana-dashboards icon indicating copy to clipboard operation
grafana-dashboards copied to clipboard

Make it easier to customize node selector

Open minrk opened this issue 4 years ago • 4 comments

node queries are mostly selected with node names, e.g. node=~".*user.*". This often works, but I wonder if making this customizable is feasible? E.g. specifying the node label and value pattern in some variable?

For instance, I could imagine the node usage metrics using sum(metric) by (label_cloud_google_com_gke_nodepool) to automatically get metrics by node pool or some such.

minrk avatar Jun 22 '21 11:06 minrk

@minrk yeah, I started moving everything to using labels in cluster.jsonnet, it should be the case everywhere.

yuvipanda avatar Jun 22 '21 18:06 yuvipanda

Need to make sure it works for AWS as well though.

yuvipanda avatar Jun 22 '21 18:06 yuvipanda

yeah, I don't have a good grasp on how variables work (whether in jsonnet or grafana) to know, but it seems we could specify a "node pool node label" in a variable and use that. I don't know if that needs to be a template variable as opposed to a grafana one, though

minrk avatar Jun 22 '21 18:06 minrk

I think of these as 'build time' changes, so we can probably make the deployer try to detect what labels are present somehow and determine what the queries should be?

yuvipanda avatar Jun 22 '21 18:06 yuvipanda