notebook
notebook copied to clipboard
Modify test file to avoid `check-wheel-content` duplicate file error
In attempting to make a release for 6.5.x, during jupyter-releaser check-python, check-wheel-content gives a duplicate file error: https://github.com/jupyter/notebook/actions/runs/8851516368/job/24308219469
No new CI failures due to changes in this PR, however, it seems that the Python Tests CI failures on Macos, which were previously passing, are now failing due to macos-latest using macos-14 which uses M1 runners now, where previously the most recent CI tests had used, macos-12.7.3. If I understand correctly, based on the matrix for macos-14 currently support is only for Python versions 3.11 and 3.12.
I have specified the use of macos-12 in the Python Tests workflow for 6.5.x in another PR, currently a draft (https://github.com/jupyter/notebook/pull/7344) which also aims to resolve other CI issues.
I was also wondering if the main branch may be affected as well, but I noticed it uses actions/setup-python@v5 while 6.5.x uses actions/setup-python@v1 and the issues in the actions/setup-python repo mention there was a recent fix that should address the issue in the action. Maybe after the next release of the actions/setup-python with the fix included, it would be resolved?
cc @jtpio, @krassowski for feedback and thoughts
Jumping across actions/setup-python versions should be mostly painless, there were not many breaking changes with the default options.
Maybe we could also just ignore that duplicate file error for now, to be able to move forward with the release?
For reference this was also an issue with the JupyterLab extension cookiecutter, which still has it ignored here:
https://github.com/jupyterlab/extension-cookiecutter-ts/blob/4111b5d2fb7981ec4af3c4694b7b7ae6134bf497/%7B%7Bcookiecutter.python_name%7D%7D/pyproject.toml#L87-L88
Thank you both for your feedback! I have updated this PR to ignore the check and since the CI failures are not related to the PR I will go ahead and merge this and continue with the release.