notebook icon indicating copy to clipboard operation
notebook copied to clipboard

Folder Rename and Delete buttons remain during folder navigation

Open matthewgasbarro opened this issue 1 year ago • 1 comments
trafficstars

Description

When in the file browser view of Jupyter Notebook, double clicking a folder to view its contents displays the folder Rename and Delete buttons at the top of the file browser widget, but remain once the clicked folder's contents are displayed and no folders or files are checked.

Reproduce

  1. Go to File Browser
  2. Click on any folder. Notice the Rename and Delete buttons appear.
  3. Double click the folder
  4. See that Rename and Delete remain visible even though no folder or file is checked. Clicking on either button is a no-op.
  5. Checking any file or folder and then unchecking will cause the buttons to disappear.

Expected behavior

The Rename and Delete buttons should not be visible if no file or folder is checked.

Context

Notebook 7.1.2

chrome_3sYoVUvX7J

matthewgasbarro avatar Apr 17 '24 19:04 matthewgasbarro

Thanks @matthewgasbarro for reporting :+1:

This is indeed an issue. Maybe we'll need something like https://github.com/jupyterlab/jupyterlab/issues/14598 to be implemented in JupyterLab, to simplify the logic of which buttons should be displayed.

jtpio avatar May 01 '24 18:05 jtpio