Update to Lumino 2

[afshin]

trafficstars

Resolves https://github.com/jupyter/notebook/issues/6538

[github-actions[bot]]

:point_left: Launch a Binder on branch afshin/notebook/lumino-2

[jtpio]

Thanks @afshin for starting this.

Do you want to take over the lab 4.0.0a27 update as well, which was started in https://github.com/jupyter/notebook/pull/6525 and has some overlap with the current PR? If so happy to close https://github.com/jupyter/notebook/pull/6525 then.

There are a couple of items to have a look listed in the top comment: https://github.com/jupyter/notebook/pull/6525#issue-1352449191

[afshin]

@jtpio, sounds like a plan! I may ask you for advice if I run into any headaches 🤕

[afshin]

This migration will need to wait for a version of Lumino that includes the bug fix for startup plugins not activating and a new version of JupyterLab based with updated Lumino libraries.

• https://github.com/jupyterlab/lumino/pull/391
• https://github.com/jupyterlab/jupyterlab/pull/13062

[jtpio]

Looks like there is a new error coming from jupyter_ydoc: https://github.com/jupyter/notebook/actions/runs/3145280672/jobs/5112365511

lerna ERR! yarn run build:prod stderr:
Traceback (most recent call last):
  File "/tmp/build-env-sga8vbqf/bin/jupyter-labextension", line 5, in <module>
    from jupyterlab.labextensions import main
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyterlab/labextensions.py", line 37, in <module>
    from .labapp import LabApp
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyterlab/labapp.py", line 15, in <module>
    from jupyter_server_ydoc.ydoc import JupyterSQLiteYStore
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyter_server_ydoc/__init__.py", line 6, in <module>
    from .ydoc import YDocWebSocketHandler
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyter_server_ydoc/ydoc.py", line 11, in <module>
    from jupyter_ydoc import ydocs as YDOCS  # type: ignore
  File "/tmp/build-env-sga8vbqf/lib/python3.10/site-packages/jupyter_ydoc/__init__.py", line 1, in <module>
    import pkg_resources

EDIT: opened https://github.com/jupyter-server/jupyter_ydoc/issues/58

[jtpio]

EDIT: opened jupyter-server/jupyter_ydoc#58

https://github.com/jupyter-server/jupyter_ydoc/issues/58 has been merged and released, restarting the CI checks now.

[jtpio]

I updated the top comment with a list of items to check while doing this update: https://github.com/jupyter/notebook/pull/6539#issue-1363038765

[jtpio]

FYI @afshin I'll be pushing a couple more updates to the branch directly.

[jtpio]

A side-effect of grabbing https://github.com/jupyterlab/jupyterlab/pull/13074 from upstream is the change of the Running tab:

I would say it's fine to keep it that way in this PR. We can revisit later whether we want to switch back to the previous look:

[jtpio]

Alright CI is all passing now :heavy_check_mark:

I also did a quick check on Binder and it seems to be looking good there as well.

Found a new issue when opening a JSON file with the code editor, but it seems to be happening in JupyterLab too. Opened https://github.com/jupyterlab/jupyterlab/issues/13170 so it can be fixed upstream.

[afshin]

Thank you @jtpio!