notebook icon indicating copy to clipboard operation
notebook copied to clipboard

Split the help extension into multiple plugins

Open jtpio opened this issue 4 years ago • 2 comments
trafficstars

Problem

At the moment the help plugin is all contained in a single plugin:

https://github.com/jupyterlab/retrolab/blob/752e21fde9fbd995f2ab006a5c8650f7ae55a1f0/packages/help-extension/src/index.tsx#L42-L166

Ideally the functionalities would be split into multiple plugins, similar to JupyterLab:

https://github.com/jupyterlab/jupyterlab/blob/master/packages/help-extension/src/index.tsx

This would make it easier for downstream projects or end users to disable some of the help plugins, for example the about dialog which is being replaced in JupyterLite:

https://github.com/jtpio/jupyterlite/blob/a198d902908483f8eea36fecae858cbd14b4a078/packages/application-extension/src/index.tsx#L63-L156

Proposed Solution

Split plugins in the help-extension package like in JupyterLab:

https://github.com/jupyterlab/jupyterlab/blob/master/packages/help-extension/src/index.tsx

jtpio avatar Jun 10 '21 12:06 jtpio

Hi @jtpio , I would like to work on this issue. Could you please assign me?

rixant avatar Jun 17 '22 13:06 rixant

Sure thing, thanks @Rixant!

jtpio avatar Jun 17 '22 13:06 jtpio

Hi @jtpio, I noticed that this issue doesn't have a PR to be merged. I opened a draft PR in hopes of being able to address it, I hope that's okay.

RRosio avatar Jan 18 '23 02:01 RRosio

Yes, many thanks @RRosio!

jtpio avatar Jan 18 '23 08:01 jtpio