notebook icon indicating copy to clipboard operation
notebook copied to clipboard

Adds left and right panels

Open JasonWeill opened this issue 3 years ago • 10 comments
trafficstars

Addreses #6326 by adding a left and right panel to Jupyter Notebook.

Adapted from https://github.com/jupyterlab/retrolab/pull/275 which was to address https://github.com/jupyterlab/retrolab/issues/272.

JasonWeill avatar Mar 24 '22 00:03 JasonWeill

Binder :point_left: Launch a Binder on branch jweill-aws/notebook/left-right-widgets

github-actions[bot] avatar Mar 24 '22 00:03 github-actions[bot]

Is there an update on this ? Are any features missing ?

brichet avatar Jul 20 '22 09:07 brichet

I think one of the blockers was being able to reuse the table of contents extension from JupyterLab in Notebook v7.

It was not easily possible for a while but should be possible now with the latest JupyterLab 4.0.0ax pre-releases.

jtpio avatar Jul 20 '22 12:07 jtpio

It was not easily possible for a while but should be possible now with the latest JupyterLab 4.0.0ax pre-releases.

In particular https://github.com/jupyterlab/jupyterlab/pull/12374 which was released in 4.0.0a25: https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0a25.

jtpio avatar Jul 20 '22 12:07 jtpio

@jweill-aws were you planning to resume work on this branch?

jtpio avatar Jul 20 '22 13:07 jtpio

@jtpio I am actively working on a different project at the moment. I don't have a plan to resume work on this item in the near term.

JasonWeill avatar Jul 20 '22 16:07 JasonWeill

Thanks for answering. I'll take a look at it as soon as possible.

brichet avatar Jul 21 '22 06:07 brichet

I rebased the PR and added the TOC dependency here. The table of contents exists in left menu but is empty.

The widget is null after : https://github.com/jupyterlab/jupyterlab/blob/039934615eae2405f82a071152d8da8ee432727e/packages/toc-extension/src/index.ts#L274

It seems that the app.restored is resolved before the document is attached to the main area.

brichet avatar Jul 21 '22 16:07 brichet

Thanks @jweill-aws and @brichet.

I don't have a plan to resume work on this item in the near term.

@brichet maybe we can open a new PR based on this commit and continue there?

jtpio avatar Jul 25 '22 07:07 jtpio

@brichet maybe we can open a new PR based on this commit and continue there?

I opened https://github.com/jupyter/notebook/pull/6487

brichet avatar Jul 25 '22 11:07 brichet