nbformat icon indicating copy to clipboard operation
nbformat copied to clipboard

Should normalize update minor_version?

Open vidartf opened this issue 2 years ago • 1 comments
trafficstars

Currently if I run a v 4.0 notebook through nbformat.validator.normalize, it will add cell ids, but it will leave the minor version as 0. Shouldn't it be updated to 5 to highlight that it now includes some fields that was added in that version of the schema? Since the previous versions have the schema with additionalProperties: false, the new notebook will be invalid against the 4.0 schema.

vidartf avatar Nov 23 '22 00:11 vidartf

Yes, it makes sense to me that whenever a normalize occurs, it should bump to the version that was used to normalize.

blink1073 avatar Nov 23 '22 02:11 blink1073