jupyter-sphinx icon indicating copy to clipboard operation
jupyter-sphinx copied to clipboard

Published 20 hours ago • verified publisher icon jupyter

Fix flaky windows tests

Open akhmerov opened this issue 5 years ago • 6 comments

There's a warning about IOPub timeout and the failures are nondeterministic.

akhmerov avatar Aug 27 '20 15:08 akhmerov

perhaps the hackiest-but-fastest thing to do is to add a couple of catches to re-run this test if it fails with that error automatically. That way the test would only fail if it fails 3 times in a row or something

choldgraf avatar Sep 21 '20 17:09 choldgraf

NB This seems to be the same issue: https://github.com/mwouts/jupytext/issues/489

The solution from jupytext side was to skip all tests that execute notebooks on windows...

akhmerov avatar Sep 21 '20 17:09 akhmerov

theres a pytest plugin for that: https://github.com/pytest-dev/pytest-rerunfailures

chrisjsewell avatar Sep 21 '20 17:09 chrisjsewell

but the more complete fix would be to add an IOPub timeout option to parse to nbclient

chrisjsewell avatar Sep 21 '20 17:09 chrisjsewell

https://github.com/jupyter/nbclient/blob/09dbc75ac83e3df322a2a9fb614d4c82f40b6fe9/nbclient/client.py#L176

chrisjsewell avatar Sep 21 '20 17:09 chrisjsewell

Didn't seem to help on jupytext side: https://github.com/mwouts/jupytext/issues/489#ref-commit-7d73894

There's a draft PR against nbconvert, that claims to fix this https://github.com/jupyter/nbconvert/pull/1183

akhmerov avatar Sep 21 '20 17:09 akhmerov