xeus-python icon indicating copy to clipboard operation
xeus-python copied to clipboard

Inconsistency in IPython for image _repr_*_ your thoughts ?

Open Carreau opened this issue 6 years ago • 3 comments

See https://github.com/ipython/ipython/issues/11841,

IPython seem to sometime return base64 str, and sometime return raw data depending on the type of the object (lib.display.Image vs matplotlib.Figure for example).

I haven't checked how that affect data on the wire when you use ipykernel, but as you have spent more time than me recently on the protocol; maybe this is something you have observed; and have thoughts on.

I'm tempted to change IPython to always return bytes, but just want to know your thoughts.

Carreau avatar Aug 01 '19 16:08 Carreau

Thanks for the heads up @Carreau! We will definitely pay attention to this. I am a bit swamped at the moment but will get back into it later.

SylvainCorlay avatar Aug 01 '19 16:08 SylvainCorlay

No problem, and no hurry.

Things have been working for years; but consistency (and less code path) is always a good thing.

Carreau avatar Aug 01 '19 16:08 Carreau

@martinRenou is this an issue we can close now?

SylvainCorlay avatar Apr 17 '20 12:04 SylvainCorlay