widget-ts-cookiecutter icon indicating copy to clipboard operation
widget-ts-cookiecutter copied to clipboard

Quote watch argument

Open gagern opened this issue 2 years ago • 1 comments
trafficstars

I tried following the README:

https://github.com/jupyter-widgets/widget-ts-cookiecutter/blob/94f9d384331150655c18a08d94307280c32adedd/README.md?plain=1#L94-L95

The yarn run watch failed for me, using node v16.17.1 and yarn 3.4.1:

No matches found: "watch:*"

It works if I run node_modules/.bin/npm-run-all -p 'watch:*' in shell. It also works if I quote the argument. Looks to me like something is trying to expand that glob before invoking the binary. strace shows that the command doesn't get passed to sh -c as a whole. And npm-run-all isn't even executed so the error message is not coming from it. On the plus side, the fact that apparently these commands get executed by code inside node means portability should be no concern, and if single quotes work for me they hopefully work for everyone.

gagern avatar Mar 05 '23 13:03 gagern

I second this - I used node v18.15.0 and yarn 3.5.1. The yarn run watch command failed for me as well, and only worked when I quoted the argument.

AnthonyAndroulakis avatar May 24 '23 15:05 AnthonyAndroulakis