ipywidgets icon indicating copy to clipboard operation
ipywidgets copied to clipboard

Update yarn version in dev installation documentation

Open trungleduc opened this issue 2 years ago • 4 comments
trafficstars

trungleduc avatar Jun 27 '23 16:06 trungleduc

Binder :point_left: Launch a binder notebook on branch trungleduc/ipywidgets/update-dev-doc

github-actions[bot] avatar Jun 27 '23 16:06 github-actions[bot]

I thought we needed <2 everywhere, and this is also what is in https://github.com/jupyter-widgets/ipywidgets/blob/main/docs/source/dev_release.md and what I used for releasing.

maartenbreddels avatar Jun 27 '23 20:06 maartenbreddels

I saw It is bumped to version 3 in the readme in the last PR. The yarn 1 config file is also replaced with the yarn 3 one.

trungleduc avatar Jun 27 '23 20:06 trungleduc

I saw It is bumped to version 3 in the readme in the last PR. The yarn 1 config file is also replaced with the yarn 3 one.

Yeah, actually the bump to requiring Yarn 3 was done in 8c08faf4a1b634503255b66f6e5a550685f0423b — I just updated the README and the Binder scripting to match, plus shook out some of the consequences of the change (like dropping a yarn plugin that's only compatible with version 1).

Looks like https://github.com/jupyter-widgets/ipywidgets/blob/main/docs/source/dev_release.md should be updated as well. Running yarn set version stable from the ipywidgets repo root directory will switch to using Yarn 3 locally, even on systems where the yarn command is otherwise version 1.

ferdnyc avatar Aug 22 '23 11:08 ferdnyc

It seems this PR is outdated and the yarn version was fixed in another PR, sorry @trungleduc

martinRenou avatar Aug 22 '24 09:08 martinRenou