ipyleaflet
ipyleaflet copied to clipboard
jupyter-widgets
Add subitems to layers (either layers or controls or a mixture of both)
Add subitems to layers (either layers or controls or a mixture of both).
Could you rebase on master?
Thanks for the review. Rebase has been made.
It would be great to add a galata test for this :)
A notebook has been added in ui-tests/notebooks in e0b19ac, to test adding subitems in layers and check that they correctly display.
The CI tests are now green. Is there other things I may add or check ?
Thanks! I will give the PR a try. I suspect there is a bug when you create the map in a first Notebook cell, and add the layers with sub-layers in a separate cell.
I suspect there is a bug when you create the map in a first Notebook cell, and add the layers with sub-layers in a separate cell.
Indeed there is an issue when the Map is shown before adding the layers with sub-items, as seen in this screenshot (the first map view does not have the subitems visible, the second map view has them):
