naas icon indicating copy to clipboard operation
naas copied to clipboard

Isolate Naas install from other python libraries

Open jravenel opened this issue 3 years ago • 4 comments

We need to isolate Naas install from other python libraries to enable https://github.com/jupyter-naas/awesome-notebooks/issues/209 for example.

People could install python lib different from the one installed in Naas.

FYI @riderx

jravenel avatar Mar 21 '22 11:03 jravenel

yes same issue i got for Supabase, the goto seems to use virtual env : https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments/

riderx avatar Mar 21 '22 18:03 riderx

yes same issue i got for Supabase, the goto seems to use virtual env : https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments/

Yes @riderx we need to implement this it's in the roadmap. It will be easier for everyone I think 👍

Dr0p42 avatar Mar 21 '22 18:03 Dr0p42

Somthing like that python -m pip install --upgrade pip virtualenv should be added there https://github.com/jupyter-naas/naas/blob/be6dadb5c64f4d5783038a43a04419cef29dc192/.github/workflows/deploy_packages.yml#L29

riderx avatar Mar 21 '22 18:03 riderx

Somthing like that python -m pip install --upgrade pip virtualenv

The thing is that we will install naas + naas dependencies in its own virtualenv, then before running naas we will activate that venv. It will then be isolated.

I already have a branch on that which I need to push.

It's mostly happening in the Dockerfile. I will check about the CI as well.

Dr0p42 avatar Mar 21 '22 18:03 Dr0p42