jupyterlab-lsp icon indicating copy to clipboard operation
jupyterlab-lsp copied to clipboard

Handle priority change

Open jtpio opened this issue 10 months ago • 1 comments

References

This was originally brought up in https://github.com/jupyterlab/jupyterlab/issues/17147.

Opening this PR early to start exploring a way to handle dynamic updates when the priorities change, and implement the following TODO:

https://github.com/jupyter-lsp/jupyterlab-lsp/blob/ec483e9aee36f82c87e56e44e72ab89d27db8729/packages/jupyterlab-lsp/src/index.ts#L178

Code changes

On settings update, check if priorities changed and if so, reset the connection.

User-facing changes

Quickly testing locally, this seems to produce the desired effect (lsp section update updated in the panel, and different completions based on which server is active):

jupyterlab-lsp-reload-connection.webm

Backwards-incompatible changes

Chores

  • [ ] linted
  • [ ] tested
  • [ ] documented
  • [ ] changelog entry

jtpio avatar Jan 08 '25 15:01 jtpio

Binder :point_left: Launch a binder notebook on branch jtpio/jupyterlab-lsp/handle-priority-change

github-actions[bot] avatar Jan 08 '25 15:01 github-actions[bot]

Ah, sorry wanted to click "update branch".

krassowski avatar Jul 18 '25 13:07 krassowski

@jtpio are you interested in finalising this PR?

krassowski avatar Aug 22 '25 14:08 krassowski

At some point yes, but will probably not have the bandwidth in the coming weeks / months.

jtpio avatar Aug 22 '25 15:08 jtpio