jupyterlab-lsp icon indicating copy to clipboard operation
jupyterlab-lsp copied to clipboard

Fixed broken Julia LSP support + fixed broken MarkDown LSP support

Open alberti42 opened this issue 1 year ago • 2 comments
trafficstars

References

  • It fixes MarkDown support that was broken. It replaces the broken unified-language-server with vscode_markdown_languageserver. See issues raised at https://discourse.jupyter.org/t/how-to-install-and-run-markdown-language-server/24286/3
  • It fixes support for Julia LSP. There were several mistakes in how to LSP server was called; see notes in the commits.

Code changes

Changes are documented in the commits.

User-facing changes

No visual changes in the settings.

Backwards-incompatible changes

No changes to API.

Chores

  • [ ] linted
  • [ ] tested
  • [ ] documented
  • [ ] changelog entry

I am glad to contribute to all chores if the PR will be considered and the bugs eventually fixed upstream. Before investing more time, I prefer to wait for some reactions from the maintainers. Thanks for your understanding.

Changes are anyhow very limited and small in their extent.

alberti42 avatar Oct 06 '24 01:10 alberti42

Binder :point_left: Launch a binder notebook on branch alberti42/jupyterlab-lsp/main

github-actions[bot] avatar Oct 06 '24 01:10 github-actions[bot]

Thank you for the PR, sorry I missed it back in October!

krassowski avatar Jan 08 '25 12:01 krassowski