LiTS---Liver-Tumor-Segmentation-Challenge icon indicating copy to clipboard operation
LiTS---Liver-Tumor-Segmentation-Challenge copied to clipboard

Performance issue in /LiTS/data_input (by P3)

Open DLPerf opened this issue 4 years ago • 1 comments

Hello! I've found a performance issue in dataset_input.py: dataset.batch(batch_size)(line 109) should be called before dataset.map(_parse_function)(line 107) and dataset.map(_preprocess_function)(line 108), which could make your program more efficient.

Here is the tensorflow document to support it.

Besides, you need to check the function _preprocess_function called in dataset.map(_preprocess_function) whether to be affected or not to make the changed code work properly. For example, if _preprocess_function needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf avatar Aug 27 '21 13:08 DLPerf

Hello, I'm looking forward to your reply~

DLPerf avatar Nov 04 '21 09:11 DLPerf

Hello, I'm looking forward to your reply~

thank you for your suggestion,i have converted tf code to pytorch,and using pytorch dataset load the dataset,you can find the pytorch project from here:https://github.com/junqiangchen/PytorchDeepLearing

junqiangchen avatar Oct 18 '22 05:10 junqiangchen