intro-skipper icon indicating copy to clipboard operation
intro-skipper copied to clipboard

[Feature request] automatic skip only when the client does not support the use of the skip button

Open jumoog opened this issue 1 year ago • 31 comments
trafficstars

Known Clients

AppName Support Button
Jellyfin Web x
Android TV
Jellyfin Android x
Findroid x
Jellyfin Media Player If enabled

jumoog avatar Jul 01 '24 11:07 jumoog

This means that it will check for the AppName, and only skip automatically if the AppName is Android TV.

jumoog avatar Jul 01 '24 11:07 jumoog

There is also jellyfin mpv shim. https://github.com/jellyfin/jellyfin-mpv-shim

Dnkhatri avatar Jul 02 '24 06:07 Dnkhatri

There is also jellyfin mpv shim. https://github.com/jellyfin/jellyfin-mpv-shim

That shouldn't require skipping automatically.

AbandonedCart avatar Jul 02 '24 12:07 AbandonedCart

Is this issue here that Android TV can't support a skip or that someone developing the app didn't support a skip? As someone who develops for Android TV, I can confidently say the only difference is that the devices don't have a touchscreen.

AbandonedCart avatar Jul 02 '24 12:07 AbandonedCart

I think people only want autoskipping on devices that don't support a skip button, since enabling autoskip forces skipping on all devices. Additionally, someone on Discord mentioned that on Android TV, skipping by pressing the enter/OK key still works, but the button itself isn't visible.

rlauuzo avatar Jul 02 '24 12:07 rlauuzo

I would assume the button would have worked. Android typically translates the gamdpad and controller keys into keyboard equivalents for processing.

But I can also see where they would use a native media player over the one provided by a WebView because the browser support on Android TV has always been lacking.

AbandonedCart avatar Jul 02 '24 13:07 AbandonedCart

I think people only want autoskipping on devices that don't support a skip button, since enabling autoskip forces skipping on all devices.

This is correct, I had originally mentioned this in the Discord for that exact reason. As for someone who swaps between Android TV and my computer, i'd rather skip myself on my computer than have it automatically force me to skip, whereas on the Android TV app, no skip button is present.

JamsRepos avatar Jul 02 '24 13:07 JamsRepos

@jumoog It may be time to abandon trying to force an auto skip for Android TV and consider an alternate approach. It hasn't gained any support and I remember it being proposed and shot down at least once before.

Typically, things like that translate the components when there is a fitting counterpart. It's very common that alerts or notices get translated to toast or snackbar messages. That would open up the ability to post a popup saying "press ok to skip"

AbandonedCart avatar Jul 02 '24 14:07 AbandonedCart

Another approach would be to insert chapters. Or we could modify the Android TV app, but I really don't want to do that.

jumoog avatar Jul 02 '24 16:07 jumoog

Is there any reason the hardware buttons aren't a viable option?

AbandonedCart avatar Jul 02 '24 17:07 AbandonedCart

Is there any reason the hardware buttons aren't a viable option?

Unless you force a message to the client saying "Press this button on your controller to skip" consistently each time an intro segment appears, I don't see this as a viable option. You can't really expect users to know about something like that when they're not told. Although, i'm not too sure what the issue you're referring to for auto skipping is, possibly to do with web sockets? Which my solution would also require.

JamsRepos avatar Jul 02 '24 17:07 JamsRepos

The offical Jellyfin Android TV App dont use the server website. So there is no button you can press.

jumoog avatar Jul 02 '24 17:07 jumoog

The offical Jellyfin Android TV App dont use the server website. So there is no button you can press.

My thoughts exactly, it's almost it's own bespoke application. I think there's major confusion going on inside this feature request.

JamsRepos avatar Jul 02 '24 18:07 JamsRepos

Does Android TV not have a remote / controller anymore?

AbandonedCart avatar Jul 02 '24 18:07 AbandonedCart

Does Android TV not have a remote / controller anymore?

We have a remote control, but nothing to click/skip. This is why we need to send a seek command.

jumoog avatar Jul 02 '24 18:07 jumoog

And didn't @rlauuzo say that executing the button worked, but it was the UI component that was missing.

AbandonedCart avatar Jul 02 '24 18:07 AbandonedCart

And didn't @rlauuzo say that executing the button worked, but it was the UI component that was missing.

Maybe he meant the Android app? This may work if you sideload the app, but you can only download the Android TV app from the Play Store.

jumoog avatar Jul 02 '24 18:07 jumoog

If this really is the situation, the Android TV app hardly seems worth downloading.

Having a regular app support Android TV is not an overly involved process, so there has to be some underlying reason to make it a completely separate project. I can't see sabotage being that reason.

AbandonedCart avatar Jul 02 '24 18:07 AbandonedCart

Well, I bought a cheap Google Chromecast 4k and the Android TV app is the only one you can download 😂

jumoog avatar Jul 02 '24 18:07 jumoog

thats the current Intro Skip button situation https://github.com/jellyfin/jellyfin-androidtv/issues/1800

jumoog avatar Jul 02 '24 18:07 jumoog

And didn't @rlauuzo say that executing the button worked, but it was the UI component that was missing.

Maybe he meant the Android app? This may work if you sideload the app, but you can only download the Android TV app from the Play Store.

Someone on Discord mentioned that it works on their Fire TV Stick even though the button doesn't appear. I don't have an Android TV device to test it myself.

rlauuzo avatar Jul 02 '24 18:07 rlauuzo

I will test it shortly, I am about to stick a show on anyways.

JamsRepos avatar Jul 02 '24 18:07 JamsRepos

I dont see any API calls for our Plugin in the code. Maybe that person used a webview?

jumoog avatar Jul 02 '24 18:07 jumoog

Can confirm it does not exist on Android TV client.

JamsRepos avatar Jul 02 '24 18:07 JamsRepos

I'm looking into what they're using to see what options are available.

It's ExoPlayer. It also seems like they are still in the earlier stages of implementing the full potential of the hardware. I guess throwing together a workaround is going to be the only answer available immediately.

AbandonedCart avatar Jul 02 '24 19:07 AbandonedCart

Should add the Roku app and Swiftfin ?

ethaldeman avatar Jul 04 '24 02:07 ethaldeman

I would assume webOS too, with third party clients such as Infuse (although I’m not sure if the API is listened to on Infuse).

JamsRepos avatar Jul 04 '24 05:07 JamsRepos

I would assume webOS too, with third party clients such as Infuse (although I’m not sure if the API is listened to on Infuse).

webOS uses the Jellyfin Server Webinterface. So it has a skip button

jumoog avatar Jul 04 '24 06:07 jumoog

I would assume webOS too, with third party clients such as Infuse (although I’m not sure if the API is listened to on Infuse).

webOS uses the Jellyfin Server Webinterface. So it has a skip button

Oh nice, didn’t know that.

JamsRepos avatar Jul 04 '24 06:07 JamsRepos

Daft opinion: what about a selection where you can opt in auto-skipping for selected devices? So instead, you dont need to catch all in your code, the user could just chose in their settings? IDK.

Brramble avatar Jul 04 '24 12:07 Brramble