nodebb-plugin-sso-facebook icon indicating copy to clipboard operation
nodebb-plugin-sso-facebook copied to clipboard

download user profile picture from graph api

Open sarim opened this issue 9 years ago • 2 comments
trafficstars

fixes #25

sarim avatar Nov 23 '15 21:11 sarim

While I have no specific objections toward saving the image to disk, can we not simply link to the image directly off Facebook's servers?

Also we might want to link this into image upload hooks... might be easier than saving to disk directly.

julianlam avatar Nov 23 '15 21:11 julianlam

Actually I don't have previous experience with nodebb, so i may not be able to follow correct programming convention here.

In my experience, the image links from facebook aren't permanent. They expire/same link doesn't work for every user etc...

About image upload hooks, it seems like User.uploadFromUrl isn't implemented.

        if (!plugins.hasListeners('filter:uploadImage')) {
            return callback(new Error('[[error:no-plugin]]'));
        }

It depends on external plugins to implement it, right? So sso plugin need to have the code for downloading the picture, right?

sarim avatar Nov 25 '15 06:11 sarim