LanguageServer.jl icon indicating copy to clipboard operation
LanguageServer.jl copied to clipboard

Published 20 hours ago • verified publisher icon julia-vscode

Extract project files tracking into function

Open jwortmann opened this issue 1 year ago • 4 comments

I noticed that the drive letter normalization from my PR #1313 was incomplete and also needs to be added for the environment changing via julia/activateenvironment here: https://github.com/julia-vscode/LanguageServer.jl/blob/0da181a8e48da14c2ac46519311e01352c7c6fca/src/requests/misc.jl#L85-L109

This exact same code is used in two places, so I extracted it into a new function track_project_files! (the diff for misc.jl on GitHub is unfortunately a bit misleading).

jwortmann avatar Aug 27 '24 16:08 jwortmann

I split the PR up into 2 commits, to make it easier to review. I'd recommend to squash the commits when merging.

jwortmann avatar Aug 28 '24 12:08 jwortmann

It would be great if this PR could be merged, because this bug is currently blocking the update of the server for clients that use uppercase drive letters.

jwortmann avatar Sep 14 '24 13:09 jwortmann

Bump :shrug:

Does anybody read issues and pull requests in this repository and is able to merge this? The changes are really simple and it shouldn't take more than two minutes or so to review.

jwortmann avatar Oct 16 '24 12:10 jwortmann

Bump :shrug:

jwortmann avatar Nov 24 '24 16:11 jwortmann